Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sysadvisor): support reclaimed-core numa binding #708

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat(sysadvisor): support reclaimed-core numa binding #708

wants to merge 9 commits into from

Conversation

funnydreamwinz
Copy link
Member

Change-Id: I1058c2a6a8326e8a478e3391afe807492b2290f1

What type of PR is this?

Features

What this PR does / why we need it:

reclaimed-cores support NUMA binding

Which issue(s) this PR fixes:

Special notes for your reviewer:

@CLAassistant
Copy link

CLAassistant commented Oct 15, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@funnydreamwinz funnydreamwinz force-pushed the dev/reclaimed-core-with-numa-binding branch 9 times, most recently from 8eca181 to f3668a6 Compare October 21, 2024 09:51
@codecov Codecov
Copy link

codecov bot commented Oct 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 43.58578% with 365 lines in your changes missing coverage. Please review.

Project coverage is 55.67%. Comparing base (c364e14) to head (c788fee).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...isor/plugin/qosaware/reporter/headroom_reporter.go 14.15% 89 Missing and 2 partials ⚠️
...qrm-plugins/cpu/dynamicpolicy/cpuadvisor/cpu.pb.go 3.94% 70 Missing and 3 partials ⚠️
...ugin/qosaware/reporter/manager/resource/generic.go 40.00% 38 Missing and 4 partials ⚠️
...pu/assembler/headroomassembler/assembler_common.go 58.33% 35 Missing and 5 partials ⚠️
...nt/sysadvisor/plugin/qosaware/server/cpu_server.go 52.05% 29 Missing and 6 partials ⚠️
...sembler/headroomassembler/assembler_common_util.go 34.21% 21 Missing and 4 partials ⚠️
...resource/memory/headroompolicy/policy_canonical.go 70.21% 10 Missing and 4 partials ⚠️
...sysadvisor/plugin/qosaware/server/memory_server.go 60.00% 10 Missing and 4 partials ⚠️
.../agent/sysadvisor/plugin/qosaware/server/server.go 55.55% 6 Missing and 2 partials ⚠️
pkg/agent/sysadvisor/plugin/qosaware/qos_aware.go 45.45% 4 Missing and 2 partials ⚠️
... and 6 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #708      +/-   ##
==========================================
- Coverage   55.91%   55.67%   -0.25%     
==========================================
  Files         575      575              
  Lines       66980    67464     +484     
==========================================
+ Hits        37454    37561     +107     
- Misses      25548    25894     +346     
- Partials     3978     4009      +31
Flag Coverage Δ
unittest 55.67% <43.58%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@funnydreamwinz funnydreamwinz force-pushed the dev/reclaimed-core-with-numa-binding branch 3 times, most recently from 47e55b6 to 898dca9 Compare October 22, 2024 11:31
@funnydreamwinz funnydreamwinz force-pushed the dev/reclaimed-core-with-numa-binding branch 4 times, most recently from e1a6272 to e6419b1 Compare October 23, 2024 07:15
@funnydreamwinz funnydreamwinz force-pushed the dev/reclaimed-core-with-numa-binding branch from e6419b1 to 441975b Compare October 23, 2024 13:39
@funnydreamwinz funnydreamwinz force-pushed the dev/reclaimed-core-with-numa-binding branch from 06b7430 to 80c7417 Compare October 25, 2024 11:21
@funnydreamwinz
feat(sysadvisor): assemble headroom
c788fee 
Change-Id: Icd250c6a60d998bb9454e236baaa13c9f53c68ab
@funnydreamwinz
feat(sysadvisor): eliminate GetHeadroom API of resource advisor
1c55bb7 
Change-Id: I561b42cba90995a64895b75268076ca03611ca5d
@funnydreamwinz
feat(sysadvisor): get RNB NUMA topo
0d61465 
Change-Id: I287dc277f63289d657b1f2dafeb24094aab1ba16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nightmeng nightmeng Awaiting requested review from nightmeng

@luomingmeng luomingmeng Awaiting requested review from luomingmeng luomingmeng is a code owner

@xu282934741 xu282934741 Awaiting requested review from xu282934741 xu282934741 is a code owner

@waynepeking348 waynepeking348 Awaiting requested review from waynepeking348 waynepeking348 is a code owner

@cheney-lin cheney-lin Awaiting requested review from cheney-lin

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@funnydreamwinz @CLAassistant @cheney-lin